Add #![deny(missing_docs)] to the aes, analog, clock, and dma modules
#1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should delay this PR until #1824 as we'll have more coverage once that's merged? |
jessebraham
force-pushed
the
feature/deny-missing-docs
branch
from
da18560 to
83cf135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to just start slowly adding this attribute to modules and updating the documentation as needed. Eventually we can add it to the package root and remove all these, but I think this is the easiest path forward for now.
I've also removed the
ENCRYPT_MODEandDECRYPT_MODEconstants from theAesFlavourtrait, as they don't appear to actually be used anywhere. If they are indeed required for something let me know and I will re-add them, but they needed docstrings so I decided to just delete them instead 🤷🏻♂️