Check all features and targets in CI when linting

[MabezDev]

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

• I have updated existing examples or added new ones (if applicable).
• I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
• My changes were added to the CHANGELOG.md in the proper section.
• My changes are in accordance to the esp-rs API guidelines

Extra:

• I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖

Description

What this doesn't solve just yet:

• log/defmt, checking, I've gone with defmt for now, but ideally I'd like to check both but this would require double the CI time.
• all the packages, this mostly tackles esp-hal and esp-wifi, but I'd like 100% coverage I think this covers everything now, at the very least each package is built for each target.

Closes #1644
Closes #1693

[MabezDev]

Reminder to myself: this PR has some breaking changes (enum renaming mostly) that needs a changelog entry

[MabezDev]

This makes the clippy job take 16minutes, but I don't really see a way to reduce this. If we want everything checked, then it takes time.

[bjoernQ]

This makes the clippy job take 16minutes, but I don't really see a way to reduce this. If we want everything checked, then it takes time.

I think there is no way around that

[MabezDev]

On second review, I don't think this PR has any breaking changes, but please check my work :D

[bjoernQ]

Thanks!

[bjoernQ]

Haven't seen anything looking sus

There is one warning:

warning: constant `ESP32P4_TOML` is never used
  --> esp-metadata\src\lib.rs:10:7
   |
10 | const ESP32P4_TOML: &str = include_str!("../devices/esp32p4.toml");
   |       ^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

[JurajSadel]

LGTM, left a nitpick suggestion, feel free to ignore. Thanks!

[MabezDev]

I think I might be able to trim some old CI jobs now as they should be covered by clippy.

And provided we are still building the examples we should still detect linker issues.

Let me try.

[MabezDev]

Hmm, that worked. Now I'm wondering if I can split the clippy job into the esp-hal matrix, which might make the clippy job quicker as most of the crate should be built? Let's see :D

[MabezDev]

It helped a little bit I think, it shaved a few minutes of some of the jobs at least.

This is now ready for a final review. Before merging we need to remove the required checks on the jobs that no longer exist, and subsequent PRs should be rebased.

Edit: this also nicely closes #1644 as we're now down to 18 jobs.

[SergioGasquez]

LGTM! I like the improvements, thanks!