Add PeripheralRef::map_into
#2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
map-into
branch
2 times, most recently
from
b2e4f64 to
4b9ef27
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bugadani
force-pushed
the
map-into
branch
3 times, most recently
from
7386ec0 to
0040c40
Compare
bugadani
commented
Oct 14, 2024
| @@ -448,7 +448,7 @@ pub trait PeripheralOutput: PeripheralSignal { | |||
| } | |||
|
|
|||
| /// Trait implemented by pins which can be used as inputs. | |||
| pub trait InputPin: Pin + PeripheralInput { | |||
| pub trait InputPin: Pin + PeripheralInput + Into<AnyPin> + 'static { | |||
There was a problem hiding this comment.
These new bounds should have been added to Pin but that makes RtcPin no longer dyn compatible, which is a breaking change I do not wish to tackle here.
bugadani
commented
Oct 14, 2024
| @@ -257,6 +298,17 @@ mod peripheral_macros { | |||
| } | |||
| } | |||
|
|
|||
| #[doc(hidden)] | |||
| #[macro_export] | |||
| macro_rules! into_mapped_ref { | |||
There was a problem hiding this comment.
I'm adding this macro here, instead of in a PR that actually uses it, because I'm introducing the map_into method(s) here. Can be moved if it's an issue.
bugadani
commented
Oct 14, 2024
| /// This converts from `Peripheral<P = T>` to `Peripheral<P = U>`, | ||
| /// using an `Into` impl to convert from `T` to `U`. | ||
| #[inline] | ||
| fn map_into<U>(self) -> U |
There was a problem hiding this comment.
This is supposed to be redundant, but for some reason converting through PeripheralRef::map_into requires additional lifetime bounds that I wanted to avoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This is lifted from embassy-hal-internal to make it a bit nicer to implement peripheral type erasure.