Fix conflict between RtcClock::get_xtal_freq and Rtc::disable_rom_message_printing
#2360
Conversation
| @@ -423,7 +425,7 @@ impl<'d> Rtc<'d> { | |||
| let rtc_cntl = unsafe { lp_aon() }; | |||
| rtc_cntl | |||
| .store4() | |||
| .modify(|r, w| unsafe { w.bits(r.bits() | 1) }); | |||
| .modify(|r, w| unsafe { w.bits(r.bits() | Self::RTC_DISABLE_ROM_LOG) }); | |||
There was a problem hiding this comment.
We might be better off adding this bit to the PAC, and that would also allow us to remove the masking of this bit in L508.
There was a problem hiding this comment.
My understanding is that these registers don't have actual functionality associated with them. Instead they're a way to pass data between the bootloaders and the application. Not sure if that's a PAC thing
There was a problem hiding this comment.
I guess that's technically correct, but if we use this as something fixed-function, we might as well make our lives a bit easier :) Not sure what the team thinks, though, it's just my opinion.
There was a problem hiding this comment.
I'd say it's just a register to store arbitrary data so probably it's better to keep it as is. esp-hal might not be the only consumer of the SVDs
First commit is just some deduplication and cleanup.
See also:
espressif/esp-idf@c7c2462
Tested on the ESP32S3