Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FullDuplexMode and HalfDuplexMode type params #2373

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 21, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

The biggest change is the ability to use HD and FD devices on the same bus at the same time. The changes got a bit involved, though.

@bugadani bugadani force-pushed the spi-duplex branch 4 times, most recently from 9f9b636 to 7123905 Compare October 21, 2024 14:53
@bugadani bugadani marked this pull request as ready for review October 21, 2024 14:55
@bugadani bugadani force-pushed the spi-duplex branch 3 times, most recently from beff65e to ce59e71 Compare October 21, 2024 16:20
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bugadani bugadani force-pushed the spi-duplex branch 2 times, most recently from 9f87fd1 to 0aead7d Compare October 23, 2024 08:30
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just to be sure I also checked the examples requiring an external flash chip - still works

@bjoernQ bjoernQ enabled auto-merge October 24, 2024 07:04
@bjoernQ bjoernQ added this pull request to the merge queue Oct 24, 2024
Merged via the queue into esp-rs:main with commit 2ac4786 Oct 24, 2024
28 checks passed
@bugadani bugadani deleted the spi-duplex branch October 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants