PAC update #2378
Merged
PAC update #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominaezzz
reviewed
Oct 21, 2024
| } | ||
|
|
||
| /// Sets pull-up enable for the pin | ||
| pub fn pullup_enable(&self, enable: bool) { | ||
| get_pin_reg(PIN).modify(|_, w| w.fun_wpu().bit(enable)); |
There was a problem hiding this comment.
Might've been worth keeping the get_pin_reg function still. 😅
There was a problem hiding this comment.
It's impossible if we use ::steal() because it would return a reference to a local now. We don't have to use steal, thoguh, but it looks better to my brain than random pointer dereferencing.
There was a problem hiding this comment.
but it looks better to my brain than random pointer dereferencing
Same 😄
Dominaezzz
approved these changes
Oct 21, 2024
| lp_io.[< pin $gpionum >]().modify(|_, w| { | ||
| w.wakeup_enable().bit(wakeup).int_type().bits(level) | ||
| $( | ||
| impl $crate::gpio::RtcPin for GpioPin<$gpionum> { |
There was a problem hiding this comment.
With the new PAC update, this impl can be moved out of the macro. I'm hoping to see this in some future PR.
There was a problem hiding this comment.
That was one of the main motivators behind the relevant PAC change, and we're almost there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ripped out of #2359