-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples update, add a note for configTime() #5343
Conversation
… is supported by lwip Signed-off-by: Emil Muratov <gpm@hotplug.ru>
+ TimeProcessor is a singleton now * TimeSync event now works for esp32 platform also - Obsolete all WorldTimeApi methods, left it as a sepparate class for compatibility only Known issues: esp32 platform uses one ntp server only - espressif/arduino-esp32#5343 Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Hi @vortigont :) Thanks for taking the time! LITTLEFS was recently renamed to LittleFS. Could you please adjust your pull request? |
@me-no-dev merged with recent master changes. Tnx for the hint. |
@vortigont if this is an IDF menuconfig option, then change should be added in the lib-builder sdkconfigs, which will then propagate to arduino the next time that IDF has some updates for us :) |
OK, then I will check for lib-builder's defines and make a PR, then you can choose between this PR or lwip fix :) |
@me-no-dev looks like lib-builder won't help here since esp-idf's lwip Kconfig and lwipopts.h doesn't have proper defines to adjust SNTP_MAX_SERVERS at build time. |
Merged @vortigont thanks! |
lwip lib bundled with esp32 Arduino supports only one ntp server. Any additional servers set are just silently ignored.
This default is different from esp8266 Arduino core and very confusing. Most of the examples provided uses 3 different ntp servers for redundancy while only the first one is used actually.
Addressing issue #4964