NTP Examples: revert obsolete comment and updated Time example #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p server is supported by lwip", fixed in espressif/esp32-arduino-lib-builder#51 This reverts commit 6b10209.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SNTP: revert comments for examples including configTime() call setup.
It's been obsolete since 2.0.2 build includes this PR espressif/esp32-arduino-lib-builder#51
Updated SimpleTime example with a bit more details regarding SNTP over DHCP use case and TimeZone env setup.
Impact
none
Related links
Obsoletes #5343