-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiFiSTA - allow using DHCP again after disconnecting static IP #8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset _useStaticIp to false in WiFi.disconnect()
Thanks @JAndrassy! This is a good improvement. |
SuGlider
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It may need to be documented as this may lead to problems when the application set the Static IP once and connects/disconnects several times.
Another option would be to create a new API for just reseting it.
P-R-O-C-H-Y
approved these changes
Nov 9, 2023
JAndrassy
added a commit
to JAndrassy/arduino-esp32
that referenced
this pull request
Nov 12, 2023
espressif#8848)" This reverts commit a9a72d1.
Merged
4 tasks
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 12, 2023
espressif#8848)" (#297) This reverts commit a9a72d1. Co-authored-by: Juraj Andrassy <juraj.andrassy@gmail.com>
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 21, 2023
* IPv6 support * remove WPA2 Enterprise * fix include with newer IDF5.1 * rm `WiFiClientSecure` * "--dont-append-digest" * rm BluetoothSerial * safeboot in Tasmota project * Apply IPAddress fixes from ESP8266 esp8266/Arduino#8818 * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs --------- Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com> Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 21, 2023
* IPv6 support * remove WPA2 Enterprise * fix include with newer IDF5.1 * rm `WiFiClientSecure` * "--dont-append-digest" * rm BluetoothSerial * safeboot in Tasmota project * Apply IPAddress fixes from ESP8266 esp8266/Arduino#8818 * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs --------- Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com> Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 29, 2023
* IPv6 support * remove WPA2 Enterprise * rm `WiFiClientSecure` * "--dont-append-digest" * rm not needed librarys * safeboot in Tasmota project * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Dec 5, 2023
* IPv6 support * remove WPA2 Enterprise * rm `WiFiClientSecure` * "--dont-append-digest" * rm not needed librarys * safeboot in Tasmota project * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Dec 18, 2023
* IPv6 support * remove WPA2 Enterprise * rm `WiFiClientSecure` * "--dont-append-digest" * rm not needed librarys * safeboot in Tasmota project * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs * joltwallet/littlefs 1.11.0
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Dec 18, 2023
* revert broken IPv6 from upstream espressif#7174 * IPv6 support * remove WPA2 Enterprise * rm `WiFiClientSecure` * "--dont-append-digest" * rm not needed librarys * safeboot in Tasmota project * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs * joltwallet/littlefs 1.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset _useStaticIp to false in WiFi.disconnect()