Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiSTA - allow using DHCP again after disconnecting static IP #8848

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

JAndrassy
Copy link
Contributor

reset _useStaticIp to false in WiFi.disconnect()

reset _useStaticIp to false in WiFi.disconnect()
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@SuGlider SuGlider self-assigned this Nov 9, 2023
@SuGlider SuGlider added the Area: BT&Wifi BT & Wifi related issues label Nov 9, 2023
@SuGlider SuGlider added this to the 3.0.0 milestone Nov 9, 2023
@SuGlider
Copy link
Collaborator

SuGlider commented Nov 9, 2023

Thanks @JAndrassy! This is a good improvement.

Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It may need to be documented as this may lead to problems when the application set the Static IP once and connects/disconnects several times.

Another option would be to create a new API for just reseting it.

@me-no-dev me-no-dev merged commit a9a72d1 into espressif:master Nov 10, 2023
37 checks passed
@JAndrassy JAndrassy deleted the wifi_dhcp_restart branch November 11, 2023 03:45
JAndrassy added a commit to JAndrassy/arduino-esp32 that referenced this pull request Nov 12, 2023
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 12, 2023
espressif#8848)" (#297)

This reverts commit a9a72d1.

Co-authored-by: Juraj Andrassy <juraj.andrassy@gmail.com>
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 21, 2023
* IPv6 support
* remove WPA2 Enterprise
* fix include with newer IDF5.1
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm BluetoothSerial
* safeboot in Tasmota project
* Apply IPAddress fixes from ESP8266
esp8266/Arduino#8818
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs

---------

Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com>
Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 21, 2023
* IPv6 support
* remove WPA2 Enterprise
* fix include with newer IDF5.1
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm BluetoothSerial
* safeboot in Tasmota project
* Apply IPAddress fixes from ESP8266
esp8266/Arduino#8818
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs

---------

Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com>
Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 29, 2023
* IPv6 support
* remove WPA2 Enterprise
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm not needed librarys
* safeboot in Tasmota project
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Dec 5, 2023
* IPv6 support
* remove WPA2 Enterprise
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm not needed librarys
* safeboot in Tasmota project
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Dec 18, 2023
* IPv6 support
* remove WPA2 Enterprise
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm not needed librarys
* safeboot in Tasmota project
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs
* joltwallet/littlefs 1.11.0
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Dec 18, 2023
* revert broken IPv6 from upstream espressif#7174
* IPv6 support
* remove WPA2 Enterprise
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm not needed librarys
* safeboot in Tasmota project
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs
* joltwallet/littlefs 1.11.0
me-no-dev pushed a commit that referenced this pull request Dec 20, 2023
#8848)" (#8873)

This reverts commit a9a72d1.

Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BT&Wifi BT & Wifi related issues
Projects
Development

Successfully merging this pull request may close these issues.

5 participants