Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle u8 pointers when assigning and comparing #8818

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jan 18, 2023

raw6() is one thing left over, we sometimes have u8 scope at the end so it is not techically valid code to reinterpret like that. alignment works out, though
tbh I'd prefer we return a real value instead of pointer for our internal usage, and leave ptr access for Arduino compatibility (meaning, std::array<uint8_t, 4> and std::array<uint16_t, 8> / std::array<uint8_t, 16> and operate on that vs. weird overloads all over the place and no size checks)

@d-a-v d-a-v added the alpha included in alpha release label Jan 19, 2023
@mcspr mcspr changed the title IPAddress u8 vs u32 fixes Properly handle u8 pointers when assigning and comparing Jan 20, 2023
@mcspr mcspr merged commit 56107fb into esp8266:master Jan 20, 2023
@mcspr mcspr deleted the ipaddr/u32-copy branch January 20, 2023 09:31
@TD-er
Copy link
Contributor

TD-er commented Jan 20, 2023

Just as a compliment:
This was an extremely swift colaboration. Within 1h after reporting, a possible fix was already known and now already being merged.
Thums up!

@mcspr mcspr added this to the 3.1.2 milestone Jan 25, 2023
s-hadinger added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 1, 2023
s-hadinger added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 1, 2023
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 11, 2023
* IPv6 support
* remove WPA2 Enterprise
* fix include with newer IDF5.1
* rm `WiFiClientSecure`
* "--dont-append-digest"
* add C2
* rm BluetoothSerial
* safeboot in Tasmota project
* Apply IPAddress fixes from ESP8266
esp8266/Arduino#8818
* [ESP32-C2] Fix SPI bus number & reported flash speed/size

---------

Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com>
Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 21, 2023
* IPv6 support
* remove WPA2 Enterprise
* fix include with newer IDF5.1
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm BluetoothSerial
* safeboot in Tasmota project
* Apply IPAddress fixes from ESP8266
esp8266/Arduino#8818
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs

---------

Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com>
Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 21, 2023
* IPv6 support
* remove WPA2 Enterprise
* fix include with newer IDF5.1
* rm `WiFiClientSecure`
* "--dont-append-digest"
* rm BluetoothSerial
* safeboot in Tasmota project
* Apply IPAddress fixes from ESP8266
esp8266/Arduino#8818
* Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297)
* remove zigbee libs

---------

Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com>
Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha included in alpha release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPAddress::operator= needs 32-bit aligned pointer
3 participants