forked from espressif/arduino-esp32
-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
5e62273
commit 17dc50c
Showing
2 changed files
with
30 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@s-hadinger
In a constructor you should not call member functions, especially not when the class uses inheritance.
Also this is causing quite a chain of calls as you're using
operator=(const uint8_t*)
, which calls the constructor withuint32_t
as argument and that one usesv4() = ...
However this is extremely tricky as we're in the constructor and thus it sounds like undefined behavior to me.
Calling
setV4()
is already pushing it a bit, but using functions likev4()
which actis on references of members which may not yet be constructed is really tricky.