Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove residual Python2-specific code #3016

Closed
jngrad opened this issue Jul 25, 2019 · 1 comment · Fixed by #3026
Closed

Remove residual Python2-specific code #3016

jngrad opened this issue Jul 25, 2019 · 1 comment · Fixed by #3026
Assignees
@jngrad
Milestone
Espresso 4.1

Comments

@jngrad
Copy link
Member

jngrad commented Jul 25, 2019

There is some more Py2-specific code, mainly the use of the six module, the unicode C string wrapper and the Cython 2/3 flags in CMake. That should be removed too.

Originally posted by @mkuron in #3008 (comment)
@jngrad jngrad added this to the Espresso 4.1 milestone Jul 25, 2019
@jngrad jngrad self-assigned this Jul 28, 2019
@jngrad
Copy link
Member Author

jngrad commented Jul 29, 2019

concerning the unicode C string wrapper, we could simplify it but not remove it: when running the python, tutorials and samples tests, the first unicode conditional is hit 694 times and the second bytes conditional is hit 26685 times.

@jngrad jngrad mentioned this issue Jul 29, 2019
Merged
bors bot added a commit that referenced this issue Jul 30, 2019
@bors @jngrad
Merge #3026
1ddee80 
3026: Remove residual Python2-specific code r=fweik a=jngrad

Fixes #3016

Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
@bors bors bot closed this as completed in #3026 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jngrad jngrad

Labels
None yet
Projects
None yet
Milestone
Espresso 4.1
Development

Successfully merging a pull request may close this issue.

Remove residual Python2-specific code jngrad/espresso
1 participant
@jngrad