Remove residual Python2-specific code #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the testsuite. Python3.2 has been discontinued in 2014: https://www.python.org/downloads/release/python-326/
Reduces code duplication and avoids mistakes. Also replaced all occurences of `super(type(self), self)` with `super()` because the former is incorrect and causes an infinite recursion loop when the class is used as parent of a new class.
Codecov Report
@@ Coverage Diff @@
## python #3026 +/- ##
======================================
Coverage 82% 82%
======================================
Files 527 527
Lines 26791 26791
======================================
Hits 22080 22080
Misses 4711 4711Continue to review full report at Codecov.
|
fweik
approved these changes
Jul 30, 2019
|
bors r+ |
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2019
3029: Cleanup Sphinx documentation r=fweik a=jngrad Clean up Sphinx documentation of files affected by #3026: - apply numpydoc style (indentation level of param descriptions, show allowed param values) - remove duplicated docstrings, add missing words - use LaTeX math to display equations of constraints - fix broken Sphinx syntax (typos, unparsed `.. notes::` directives, missing links, etc.). Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3016