Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths not properly escaped in {i,}pypresso wrapper script #3237

Closed
fweik opened this issue Oct 7, 2019 · 0 comments · Fixed by #3238
Closed

Paths not properly escaped in {i,}pypresso wrapper script #3237

fweik opened this issue Oct 7, 2019 · 0 comments · Fixed by #3238
Labels
Bug
Milestone
Espresso 4.1.1

Comments

@fweik
Copy link
Contributor

fweik commented Oct 7, 2019

As reported by @jonaslandsgesell:

If the full path of the build directory contains a space then the pypresso/ipypresso scripts do not work. The paths needs to be set in quotes in the scripts. I can describe this offline.
@fweik fweik added the Bug label Oct 7, 2019
@fweik fweik added this to the Espresso 4.1.1 milestone Oct 7, 2019
@fweik fweik mentioned this issue Oct 7, 2019
Merged
bors bot added a commit that referenced this issue Oct 11, 2019
@bors @fweik
Merge #3238
6dbcec3 
3238: maintainer: Escape module python in wrapper script r=KaiSzuttor a=fweik

Fixes #3237.

Description of changes:
 - Added quotes around the module path in python wrapper script.


Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
bors bot added a commit that referenced this issue Oct 11, 2019
@bors @mkuron
@KaiSzuttor @fweik
Merge #3234 #3236 #3238
61a8df1 
3234: Fix mpiio with stdlibc++ range checking r=fweik a=mkuron

Fixes #3230. Reported by @junghans.

When mpiio was used but no bonds were present, we would still try to copy zero bonds from a zero-length vector. This triggered an assertion when stdlibc++ range checking was enabled.

Please tag for cherry-picking into 4.1.1.

3236: ESS2019 installation guide updates r=KaiSzuttor a=mkuron

Lessons learned today:

- We require MPI 3 because we depend on const-correctness in a few places. That means that OpenMPI 1.6.5 and lower are not supported anymore.
- Installing the ROCm driver breaks access to /dev/kfd, causing hwloc initialization during `mpiexec` to hang. Rebooting helps.
- Add matplotlib, ipython and jupyter to the Mac install guide.
- Homebrew now defaults to Python 3, requires manually enabling cython, and it's unclear whether the hdf5 package still supports MPI (Homebrew/homebrew-core#26974)
- Anaconda (~/anaconda[23]) and python.org packages (/Library/Python and /usr/local/bin) are also sources of conflict

Please tag for the 4.1.1 release

3238: maintainer: Escape module python in wrapper script r=jngrad a=fweik

Fixes #3237.

Description of changes:
 - Added quotes around the module path in python wrapper script.


Co-authored-by: Michael Kuron <mkuron@users.noreply.github.com>
Co-authored-by: Michael Kuron <mkuron@icp.uni-stuttgart.de>
Co-authored-by: Kai Szuttor <kai@icp.uni-stuttgart.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors bors bot closed this as completed in c1b18fd Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Espresso 4.1.1
Development

Successfully merging a pull request may close this issue.

maintainer: Escape module python in wrapper script
1 participant
@fweik