Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESS2019 installation guide updates #3236

Merged
merged 6 commits into from
Oct 11, 2019
Merged

ESS2019 installation guide updates #3236

merged 6 commits into from
Oct 11, 2019

Conversation

mkuron
Copy link
Member

@mkuron mkuron commented Oct 7, 2019

Lessons learned today:

  • We require MPI 3 because we depend on const-correctness in a few places. That means that OpenMPI 1.6.5 and lower are not supported anymore.
  • Installing the ROCm driver breaks access to /dev/kfd, causing hwloc initialization during mpiexec to hang. Rebooting helps.
  • Add matplotlib, ipython and jupyter to the Mac install guide.
  • Homebrew now defaults to Python 3, requires manually enabling cython, and it's unclear whether the hdf5 package still supports MPI (HDF5 formula no longer supports mpich Homebrew/homebrew-core#26974)
  • Anaconda (~/anaconda[23]) and python.org packages (/Library/Python and /usr/local/bin) are also sources of conflict

Please tag for the 4.1.1 release

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #3236 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3236   +/-   ##
======================================
- Coverage      85%     85%   -1%     
======================================
  Files         528     528           
  Lines       25805   25805           
======================================
- Hits        22150   22149    -1     
- Misses       3655    3656    +1
Impacted Files Coverage Δ
src/core/particle_data.cpp 95% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc1e06...f191fb5. Read the comment docs.

@jonaslandsgesell
Copy link
Member

jonaslandsgesell commented Oct 7, 2019

If the full path of the build directory contains a space then the pypresso/ipypresso scripts do not work. When setting the variable PYTHONPATH the path to the espressomd module needs to be set in quotes in the scripts. I can describe this offline.

@jngrad jngrad added this to the Espresso 4.1.1 milestone Oct 7, 2019
@mkuron
Copy link
Member Author

mkuron commented Oct 7, 2019

@jonaslandsgesell, that‘s fixed in #3238 already.

doc/sphinx/installation.rst Outdated Show resolved Hide resolved
@RudolfWeeber
Copy link
Contributor

RudolfWeeber commented Oct 8, 2019 via email

@RudolfWeeber
Copy link
Contributor

RudolfWeeber commented Oct 8, 2019 via email

@RudolfWeeber
Copy link
Contributor

RudolfWeeber commented Oct 8, 2019 via email

@RudolfWeeber
Copy link
Contributor

RudolfWeeber commented Oct 8, 2019 via email

@jngrad
Copy link
Member

jngrad commented Oct 11, 2019

bors r=KaiSzuttor

bors bot added a commit that referenced this pull request Oct 11, 2019
3234: Fix mpiio with stdlibc++ range checking r=fweik a=mkuron

Fixes #3230. Reported by @junghans.

When mpiio was used but no bonds were present, we would still try to copy zero bonds from a zero-length vector. This triggered an assertion when stdlibc++ range checking was enabled.

Please tag for cherry-picking into 4.1.1.

3236: ESS2019 installation guide updates r=KaiSzuttor a=mkuron

Lessons learned today:

- We require MPI 3 because we depend on const-correctness in a few places. That means that OpenMPI 1.6.5 and lower are not supported anymore.
- Installing the ROCm driver breaks access to /dev/kfd, causing hwloc initialization during `mpiexec` to hang. Rebooting helps.
- Add matplotlib, ipython and jupyter to the Mac install guide.
- Homebrew now defaults to Python 3, requires manually enabling cython, and it's unclear whether the hdf5 package still supports MPI (Homebrew/homebrew-core#26974)
- Anaconda (~/anaconda[23]) and python.org packages (/Library/Python and /usr/local/bin) are also sources of conflict

Please tag for the 4.1.1 release

3238: maintainer: Escape module python in wrapper script r=jngrad a=fweik

Fixes #3237.

Description of changes:
 - Added quotes around the module path in python wrapper script.


Co-authored-by: Michael Kuron <mkuron@users.noreply.github.com>
Co-authored-by: Michael Kuron <mkuron@icp.uni-stuttgart.de>
Co-authored-by: Kai Szuttor <kai@icp.uni-stuttgart.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Oct 11, 2019

Canceled (will resume)

@jngrad
Copy link
Member

jngrad commented Oct 11, 2019

bors r-
(failed CI)

@bors
Copy link
Contributor

bors bot commented Oct 11, 2019

Canceled

@jngrad
Copy link
Member

jngrad commented Oct 11, 2019

bors r=KaiSzuttor

bors bot added a commit that referenced this pull request Oct 11, 2019
3234: Fix mpiio with stdlibc++ range checking r=fweik a=mkuron

Fixes #3230. Reported by @junghans.

When mpiio was used but no bonds were present, we would still try to copy zero bonds from a zero-length vector. This triggered an assertion when stdlibc++ range checking was enabled.

Please tag for cherry-picking into 4.1.1.

3236: ESS2019 installation guide updates r=KaiSzuttor a=mkuron

Lessons learned today:

- We require MPI 3 because we depend on const-correctness in a few places. That means that OpenMPI 1.6.5 and lower are not supported anymore.
- Installing the ROCm driver breaks access to /dev/kfd, causing hwloc initialization during `mpiexec` to hang. Rebooting helps.
- Add matplotlib, ipython and jupyter to the Mac install guide.
- Homebrew now defaults to Python 3, requires manually enabling cython, and it's unclear whether the hdf5 package still supports MPI (Homebrew/homebrew-core#26974)
- Anaconda (~/anaconda[23]) and python.org packages (/Library/Python and /usr/local/bin) are also sources of conflict

Please tag for the 4.1.1 release

3238: maintainer: Escape module python in wrapper script r=jngrad a=fweik

Fixes #3237.

Description of changes:
 - Added quotes around the module path in python wrapper script.


Co-authored-by: Michael Kuron <mkuron@users.noreply.github.com>
Co-authored-by: Michael Kuron <mkuron@icp.uni-stuttgart.de>
Co-authored-by: Kai Szuttor <kai@icp.uni-stuttgart.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Oct 11, 2019

Build succeeded

@bors bors bot merged commit f191fb5 into espressomd:python Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants