Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ELC and MMM2D code duplication #2725

Closed
wants to merge 20 commits into from

Conversation

reinaual
Copy link
Contributor

Fixes #2279

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #2725 into python will decrease coverage by <1%.
The diff coverage is 96%.

Impacted file tree graph

@@           Coverage Diff            @@
##           python   #2725     +/-   ##
========================================
- Coverage      79%     79%     -1%     
========================================
  Files         508     491     -17     
  Lines       27049   25272   -1777     
========================================
- Hits        21621   20193   -1428     
+ Misses       5428    5079    -349
Impacted Files Coverage Δ
...electrostatics_magnetostatics/elc_mmm2d_common.hpp 100% <100%> (ø)
src/core/electrostatics_magnetostatics/mmm2d.cpp 89% <100%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/elc.cpp 70% <89%> (-1%) ⬇️
...al_sites/lb_inertialess_tracers_cuda_interface.cpp 0% <0%> (-100%) ⬇️
...rialization/ibm_cuda_particle_velocities_input.hpp 0% <0%> (-100%) ⬇️
src/core/actor/ActorList.cpp 0% <0%> (-80%) ⬇️
src/core/EspressoSystemInterface.cpp 40% <0%> (-52%) ⬇️
...tatics_magnetostatics/magnetic_non_p3m_methods.cpp 0% <0%> (-39%) ⬇️
src/core/PartCfg.hpp 80% <0%> (-20%) ⬇️
...rc/core/grid_based_algorithms/lb_interpolation.cpp 77% <0%> (-12%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d1b12...28ebbae. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #2725 into python will increase coverage by <1%.
The diff coverage is 96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2725    +/-   ##
=======================================
+ Coverage      79%     79%   +<1%     
=======================================
  Files         508     509     +1     
  Lines       27049   26883   -166     
=======================================
- Hits        21621   21499   -122     
+ Misses       5428    5384    -44
Impacted Files Coverage Δ
...electrostatics_magnetostatics/elc_mmm2d_common.hpp 100% <100%> (ø)
src/core/electrostatics_magnetostatics/mmm2d.cpp 89% <100%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/elc.cpp 70% <89%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d1b12...86c6242. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Apr 30, 2019

Is it ready for review?

@reinaual
Copy link
Contributor Author

Yes, but @fweik wanted to wait until #2685 is finished before making any changes to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code duplication in and between MMM2d and ELC
3 participants