Enable oversubscribing in OpenMPI 2.X #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralize the TEST_NP and MPIEXEC_OVERSUBSCRIBE default value deduction mechanism to the dedicated unit_test module.
The OpenMPI -oversubscribe feature was backported to the 2.X series. Without the -oversubscribe flag, tests running on hyperthreaded CPUs with more threads than cores using OpenMPI 2.X may exit early with an exit code of 0, causing these tests to silently fail.
When no default value is provided for TEST_NP, value `nproc / 2 + 1` is used instead, which can be large on hyperthreaded CPUs. This leads to issues in parallel tests that don't scale well with a large number of cores (e.g. when there aren't enough particles) or with a large odd number of cores (e.g. LB or P3M).
Codecov Report
@@ Coverage Diff @@
## python #3335 +/- ##
======================================
- Coverage 86% 86% -1%
======================================
Files 538 538
Lines 25350 25350
======================================
- Hits 21834 21833 -1
- Misses 3516 3517 +1
Continue to review full report at Codecov.
|
fweik
approved these changes
Nov 21, 2019
mkuron
approved these changes
Nov 21, 2019
|
Yes, I checked the source code. I've also now compiled 2.0.0 on Fedora 31 and the |
reinaual
approved these changes
Nov 22, 2019
|
bors r=fweik |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2019
3334: Update io.rst r=jngrad a=jonaslandsgesell link to h5md plugin for VMD 3335: Enable oversubscribing in OpenMPI 2.X r=fweik a=jngrad Fixes #3333 3336: Fallthrough and remove duplicate line r=jngrad a=hirschsn Description of changes: - Remove a duplicated line in `topology_check_resort` by falling through as done for other cell systems in this function. PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Jonas Landsgesell <jonaslandsgesell@users.noreply.github.com> Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de> Co-authored-by: Steffen Hirschmann <steffen.hirschmann@ipvs.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3333