Fallthrough and remove duplicate line #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3336 +/- ##
========================================
- Coverage 86% 85% -1%
========================================
Files 538 511 -27
Lines 25350 23407 -1943
========================================
- Hits 21834 19932 -1902
+ Misses 3516 3475 -41
Continue to review full report at Codecov.
|
jngrad
approved these changes
Nov 22, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2019
3334: Update io.rst r=jngrad a=jonaslandsgesell link to h5md plugin for VMD 3335: Enable oversubscribing in OpenMPI 2.X r=fweik a=jngrad Fixes #3333 3336: Fallthrough and remove duplicate line r=jngrad a=hirschsn Description of changes: - Remove a duplicated line in `topology_check_resort` by falling through as done for other cell systems in this function. PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Jonas Landsgesell <jonaslandsgesell@users.noreply.github.com> Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de> Co-authored-by: Steffen Hirschmann <steffen.hirschmann@ipvs.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
topology_check_resortby falling through as done for other cell systems in this function.PR Checklist