Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests to prow presubmit #18065

Closed
ivanvc opened this issue May 24, 2024 · 3 comments · Fixed by #18314
Closed

Add integration tests to prow presubmit #18065

ivanvc opened this issue May 24, 2024 · 3 comments · Fixed by #18314
Assignees
@ivanvc
Labels
area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented May 24, 2024

What would you like to be added?

As part of the prow migration, we need to migrate some remaining GitHub workflows. Currently, integration tests have not yet migrated. They run in a matrix approach, with one, two and four CPUs.

Why is this needed?

Progress towards kubernetes/k8s.io#6102 to migrate more GitHub workflows into prow jobs.
@ivanvc ivanvc self-assigned this May 24, 2024
@ivanvc ivanvc mentioned this issue May 24, 2024
Merged
@jmhbnz jmhbnz added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 27, 2024
@ivanvc ivanvc mentioned this issue May 30, 2024
Merged
@ivanvc ivanvc mentioned this issue Jun 10, 2024
Merged
@ivanvc
Copy link
Member Author

ivanvc commented Jul 12, 2024

@jmhbnz, I think we're ready to remove arm64 workloads from GitHub actions. What do you think?

etcd/.github/workflows/tests.yaml

Lines 6 to 10 in 0e8b9b2

amd64:
uses: ./.github/workflows/tests-template.yaml
with:
arch: amd64
runs-on: ubuntu-latest

@jmhbnz
Copy link
Member

jmhbnz commented Jul 12, 2024

@jmhbnz, I think we're ready to remove arm64 workloads from GitHub actions. What do you think?

Do you mean amd64? If so I agree these are running nicely in prow now 👍🏻

@ivanvc
Copy link
Member Author

ivanvc commented Jul 12, 2024

Do you mean amd64? If so I agree these are running nicely in prow now 👍🏻

Oops, yes I meant amd

@jmhbnz jmhbnz mentioned this issue Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanvc ivanvc

Labels
area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

github: remove amd64 test actions ivanvc/etcd
2 participants
@ivanvc @jmhbnz