Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune etcd integration 1 cpu presubmit job #32685

Merged
merged 3 commits into from
May 30, 2024
Merged

Tune etcd integration 1 cpu presubmit job #32685

merged 3 commits into from
May 30, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented May 30, 2024

Now that pull-etcd-integration-1-cpu-amd64 has been running for one week, and after gathering stats from Spyglass and Grafana. I tuned the configuration, and made the job mandatory (removed optional: true), as it has been running as expected.

Part of etcd-io/etcd#18065.

@ivanvc
Tune etcd integration 1 cpu job
8830ca8 
Based on Prow's Grafana, the maximum memory usage for this job is around
1.6 GiB, set it to 3 GiB to leave some headroom. The maximum CPU used is
1.46, given this job is constrained to one CPU, I set the request and
max to 2 CPUs for headroom, which should suffice.
@ivanvc
Make etcd integration 1 cpu not optional
9d202a5 
Based on Spyglass' dashboard, the job has been consistently running, and
with the expected output for the past five days.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2024
jmhbnz
jmhbnz approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @ivanvc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit a4f43f0 into kubernetes:master May 30, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

Now that pull-etcd-integration-1-cpu-amd64 has been running for one week, and after gathering stats from Spyglass and Grafana. I tuned the configuration, and made the job mandatory (removed optional: true), as it has been running as expected.

Part of etcd-io/etcd#18065.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the tune-etcd-integration-1-cpu-presubmit-job branch June 6, 2024 22:31
@ivanvc
Copy link
Member Author

ivanvc commented Jun 6, 2024

Linking to kubernetes/k8s.io#6102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@jmhbnz jmhbnz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanvc @k8s-ci-robot @jmhbnz