Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: remove amd64 test actions #18314

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jul 13, 2024

The pull-etcd-unit-test-amd64, pull-etcd-unit-test-386, pull-etcd-integration-1-cpu-amd64, pull-etcd-integration-2-cpu-amd64, and pull-etcd-integration-8-cpu-amd64 jobs are already running on the prow infrastructure. It is safe to remove these duplicated workloads from GitHub actions.

Fixes #18065
Part of kubernetes/k8s.io#6102

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The pull-etcd-unit-test-amd64, pull-etcd-unit-test-386,
pull-etcd-integration-1-cpu-amd64, pull-etcd-integration-2-cpu-amd64
and pull-etcd-integration-8-cpu-amd64 jobs are already running on the
prow infrastructure. It is safe to remove these duplicated workloads
from GitHub actions.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code size/XS labels Jul 13, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Jul 13, 2024

Given that now the tests-template.yaml is now only used by arm64, does it make sense to remove it? Or should we leave it as is, as we'll eventually remove this when we have prow arm64 runners?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (bc9801f) to head (487af49).

Current head 487af49 differs from pull request most recent head 6325cce

Please upload reports for the commit 6325cce to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18314      +/-   ##
==========================================
- Coverage   68.96%   68.93%   -0.03%     
==========================================
  Files         417      417              
  Lines       35332    35332              
==========================================
- Hits        24366    24356      -10     
- Misses       9554     9558       +4     
- Partials     1412     1418       +6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9801f...6325cce. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit eeeb7e0 into etcd-io:main Jul 13, 2024
45 checks passed
@ivanvc ivanvc deleted the remove-amd64-test-github-actions branch August 16, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code lgtm size/XS
Development

Successfully merging this pull request may close these issues.

Add integration tests to prow presubmit
4 participants