Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdmain: unit test tls connection in client side #4177

Closed
gyuho opened this issue Jan 9, 2016 · 3 comments
Closed

etcdmain: unit test tls connection in client side #4177

gyuho opened this issue Jan 9, 2016 · 3 comments
Assignees
@gyuho
Labels
area/clientv3 area/testing

Comments

@gyuho
Copy link
Contributor

gyuho commented Jan 9, 2016

To test the following issues:

For #4135 (comment)

Would you be able to write a unit test to cover this?

We need some unit test in etcdmain to test these feature.
@gyuho gyuho self-assigned this Jan 9, 2016
@heyitsanthony
Copy link
Contributor

@xiang90 and I were discussing how we probably should have some bash script tests / bash script testing infra to end-to-end test the commands like this instead of going through the effort of writing go unit tests.

@gyuho
Copy link
Contributor Author

gyuho commented Jan 9, 2016

Yeah I agree it will be better.
For this one, I just write a simple test for the purpose of next release. Thanks

gyuho added a commit to gyuho/etcd that referenced this issue Jan 10, 2016
@gyuho
etcdmain: add TLS client, server unit tests
029e667 
For etcd-io#4177.
@gyuho gyuho mentioned this issue Jan 10, 2016
Closed
gyuho added a commit to gyuho/etcd that referenced this issue Jan 11, 2016
@gyuho
etcdmain: add TLS client, server unit tests
f25345b 
For etcd-io#4177.
gyuho added a commit to gyuho/etcd that referenced this issue Jan 11, 2016
@gyuho
*: add TLS client, server unit tests
353b0e5 
For etcd-io#4177.
And etcdmain tests with 'race' flag.
gyuho added a commit to gyuho/etcd that referenced this issue Jan 11, 2016
@gyuho
*: add TLS client, server unit tests
69bf2ca 
For etcd-io#4177.
And etcdmain tests without 'race' flag.
@gyuho
Copy link
Contributor Author

gyuho commented Jan 12, 2016

Closing this in favor of @heyitsanthony's integration testing.

@gyuho gyuho closed this as completed Jan 12, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyuho gyuho

Labels
area/clientv3 area/testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gyuho @heyitsanthony