Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add TLS client, server unit tests #4180

Closed
wants to merge 1 commit into from
Closed

*: add TLS client, server unit tests #4180

wants to merge 1 commit into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jan 10, 2016

For #4177.

@gyuho gyuho force-pushed the v2_tls_unit_test branch 2 times, most recently from f25345b to 353b0e5 Compare January 11, 2016 00:20
@gyuho gyuho changed the title etcdmain: add TLS client, server unit tests *: add TLS client, server unit tests Jan 11, 2016
@gyuho
Copy link
Contributor Author

gyuho commented Jan 11, 2016

This is only for v2.

/cc @xiang90 @heyitsanthony Please take a look. Thanks

@gyuho
*: add TLS client, server unit tests
69bf2ca 
For etcd-io#4177.
And etcdmain tests without 'race' flag.
gyuho
gyuho reviewed Jan 11, 2016
View reviewed changes
etcdmain/etcd.go
return nil, fmt.Errorf("error setting up initial cluster: %v", err)
urlsmap, token, errG := getPeerURLsMapAndToken(cfg, "etcd")
if errG != nil {
return nil, fmt.Errorf("error setting up initial cluster: %v", errG)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go vet shadow was complaining.

@gyuho
Copy link
Contributor Author

gyuho commented Jan 11, 2016

I am closing this. Guess this was unnecessary.

@heyitsanthony seems to have bash script for job control, which I think
we can use for this kind of test running binaries? I have go code that runs
etcd binaries but bash script sounds simpler.

Thanks for comments!

@gyuho gyuho closed this Jan 11, 2016
@gyuho gyuho deleted the v2_tls_unit_test branch January 31, 2016 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gyuho @xiang90 @heyitsanthony