-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If dir=true and prevExist=true but the target node is a key it turns into a dir #518
Comments
I think you mean don't PUT unless node is a dir? On Friday, January 31, 2014, Brandon Philips notifications@github.com
|
@onsi Right, fixed. |
Before adding IsKeyDir we should add tests. IsKeyDir is necessary to address etcd-io#518 on github
IsKeyDir is needed so we can check if a given key is a directory. This should be a public method because we need to check whether a request includes Dir=true in etcdserver. Addressed issue etcd-io#518 on github.
Test that if dir=true and prevExist=true PUT only if the target node is a directory. Otherwise return "Not a directory". Addresses issue etcd-io#518 on github
If dir=true and prevExist=true PUT only if the target node is a directory. Otherwise return "Not a directory". Addresses etcd-io#518 on github.
I'm doing some work to address this. |
Thoughts on the PR? |
If
dir=true
andprevExist=true
PUT only if the target node is a directory. Otherwise return "Not a directory".Via: https://github.com/coreos/go-etcd/issues/90
/cc @onsi
The text was updated successfully, but these errors were encountered: