Dir problem/518 #2147
Dir problem/518 #2147
Conversation
Before adding IsKeyDir we should add tests. IsKeyDir is necessary to address etcd-io#518 on github
IsKeyDir is needed so we can check if a given key is a directory. This should be a public method because we need to check whether a request includes Dir=true in etcdserver. Addressed issue etcd-io#518 on github.
Test that if dir=true and prevExist=true PUT only if the target node is a directory. Otherwise return "Not a directory". Addresses issue etcd-io#518 on github
If dir=true and prevExist=true PUT only if the target node is a directory. Otherwise return "Not a directory". Addresses etcd-io#518 on github.
|
Can someone take a look at this? |
|
@philips I know you're busy, but can you take a look at this when you get a chance? |
|
@iankronquist The checking logic should happen in the store not in etcd server. So can you try to make the change? |
|
So the interesting thing about this bug, as I understand it, is that the store doesn't know some key information in order to make that check, and the etcd server doesn't know whether the key is a directory. Both have really clean interfaces which prevent you from knowing both that a key is a directory and that prevExist=true at the same point in the code. I suspect this is why the bug hasn't been fixed for a year. |
Addresses issue #518
I think this fixes the issue, but I'm not sure if it's the right approach. After I dived in to the issue I realized why it sat open for a year.
I'm very open for alternate approaches.