release-3.3: bump gRPC to 1.23 #10984
Conversation
gRPC has moved the transport package to an internal-only directory. This eliminates direct use of the transport package in the stress test in favor of the error code from gRPC that represents a connection problem. https://godoc.org/google.golang.org/grpc/internal/transport is the new location for the package, which says it's not intended to be imported directly. Instead, the maintainers suggested to use the code Unavailable to detect a connection problem. This change slightly reorganizes the stresser test error handling.
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Otherwise, grpc.DialContext would just return before connection is up. Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
These changes were originally fixed in etcd-io#9860 commit 9304d1a Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
We are already backporting new balancer + new gRPC later #10980. Given 3.4 time-frame, it doesn't make sense to support two balancer implementation. If we find a bug in gRPC, we should fix based on latest balancer implementation, not on the old ones. |
|
Yea... Let us just maintain one balancer. |
While this does seem pragmatic, bumping a dependency to a patch release does not add additional support. The plan is to upgrade to new balancer once stable. At that time we would only be supporting a single balancer, not two. Introducing a new balancer to two versions does add risk. I will close this but if we find a flaw in the new balancer we should consider this as an alternative as it does not change balancer functionality for 3.3. Thanks for the review. |
#9956 has been very disruptive and while I am looking forward to the new balancer backport for 3.3 it seems practical to cut a release patching 3.3 with the old balancer then backporting the new balancer after it is stable. This would give folks an option to use the old or new balancers while having a patched release.
Backports to release-3.3 :
TODO
GRPC_GO_REQUIRE_HANDSHAKEfrom testing as it will be resolved more gracefully in 1.23.0 via https://github.com/grpc/grpc-go/pull/2904/commitsFixes #9956
/cc @gyuho @jpbetz @xiang90 @spzala @jingyih @wenjiaswe