Eliminate direct use of the gRPC transport package #9934
Conversation
functional/tester/stresser_key.go
Outdated
| @@ -178,6 +142,64 @@ func (s *keyStresser) run() { | |||
| } | |||
| } | |||
|
|
|||
| func isRetryableError(err) { | |||
There was a problem hiding this comment.
should be func isRetryableError(err error)
functional/tester/stresser_key.go
Outdated
| case etcdserver.ErrStopped.Error(): | ||
| // one of the etcd nodes stopped from failure injection | ||
| return true | ||
| case transport.ErrConnClosing.Desc: |
There was a problem hiding this comment.
Should be fixed now.
|
I vaguely remember that we use the transport pkg error since the code is not unavailable when it is returned. |
|
@xiang90 And at some point, clientv3 switched over to @mbrannock Can you address @xiang90 and @jpbetz's feedback? Then should be good to merge. |
|
Thanks everyone. Sorry about the first commit not being 100% correct. I figured out how to get my local client to build and run the tests, so I don't have to wait for travis to find problems... :-) Please take a look and let me know if there is anything else I should change. @xiang90 The gRPC dev told me that this particular transport error is translated to Unavailable. If it's coming back at something else, that might be a bug they'd be interested in. |
|
@mbrannock OK. Sounds good. LGTM |
gRPC has moved the transport package to an internal-only directory. This eliminates direct use of the transport package in the stress test in favor of the error code from gRPC that represents a connection problem. https://godoc.org/google.golang.org/grpc/internal/transport is the new location for the package, which says it's not intended to be imported directly. Instead, the maintainers suggested to use the code Unavailable to detect a connection problem. This change slightly reorganizes the stresser test error handling.
|
It looks like the failing integration test may be a flake, for it's passing on my workstation. Is there a way to rerun in Travis? |
gRPC has moved the transport package to an internal-only directory. This
eliminates direct use of the transport package in the stress test in
favor of the error code from gRPC that represents a connection problem.
https://godoc.org/google.golang.org/grpc/internal/transport is the new
location for the package, which says it's not intended to be imported
directly. Instead, the maintainers suggested to use the code Unavailable
to detect a connection problem.
This change slightly reorganizes the stresser test error handling.