etcdmain: update help message #11045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spzala
reviewed
Aug 16, 2019
etcdmain/help.go
Outdated
| @@ -206,6 +206,8 @@ Experimental feature: | |||
| ExperimentalEnableLeaseCheckpoint enables primary lessor to persist lease remainingTTL to prevent indefinite auto-renewal of long lived leases. | |||
| --experimental-compaction-batch-limit | |||
| ExperimentalCompactionBatchLimit sets the maximum revisions deleted in each compaction batch. | |||
| --experimental-peer-skip-client-san-verification | |||
There was a problem hiding this comment.
@jingyih thanks and small observation, since it's a boolean we should set it with default false similar to other such flags?. Also, on a side note I noticed that --experimental-enable-lease-checkpoint is a boolean and should set with its default false as well - if that makes sense, may be you want to update that here as well here? Thanks!
There was a problem hiding this comment.
Thanks! Looks like there are several default values missing in the help message. Updated. PTAL.
Add experimental-peer-skip-client-san-verification flag description to help message. Add default values.
jingyih
force-pushed
the
update_etcdmain_helper
branch
from
4e3b2d8
to
871c2d7
Compare
This was referenced Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
experimental-peer-skip-client-san-verificationflag description to help message.Follow up of #10524