Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: cherry-pick skip client san verification option for 3.2 version. #11195

Merged
merged 3 commits into from
Oct 9, 2019
Merged

etcdserver: cherry-pick skip client san verification option for 3.2 version. #11195

merged 3 commits into from
Oct 9, 2019

Conversation

andyliuliming
Copy link
Contributor

No description provided.

@andyliuliming andyliuliming changed the title chore: add skip client san verification option for 3.2 version too. etcdserver: add skip client san verification option for 3.2 version too. Oct 3, 2019
@andyliuliming @MartinWeindel @jingyih
etcdserver: cherry-pick skip client san verification option for 3.2 v…
e16076a 
…ersion.

Co-authored-by: Martin Weindel <martin.weindel@sap.com>
Co-authored-by: Jingyi Hu <jingyih@google.com>
Co-authored-by: Liming Liu <andyliuliming@outlook.com>
@andyliuliming andyliuliming changed the title etcdserver: add skip client san verification option for 3.2 version too. etcdserver: cherry-pick skip client san verification option for 3.2 version. Oct 3, 2019
@wenjiaswe
Copy link
Contributor

Add original PR link: #10524 . Similar to #11196, 3.2 cherry pick involves a little more code change, lgtm for me, please make sure all all related tests are tested and passed (not sure if travis test include all necessary one, e2e, functional, unit and integration).

Defer to @hexfusion to decide if this is feasible to backport to previous version. Note: this does not change the default behavior.

It would be great if you could also update the documentation: #11045, Documentation/op-guide/configuration.md and CHANGELOG.

@andyliuliming
Copy link
Contributor Author

andyliuliming commented Oct 9, 2019 •
edited
Loading

@wenjiaswe @jpbetz @gyuho thanks for the review.
updated the document &
send another PR to add the changelog (based on my imagination :) not sure that's the right change ):
#11219
because did not found the changelog file in this release branch.

@wenjiaswe
Copy link
Contributor

lgtm, thanks!

@gyuho gyuho merged commit cc959b4 into etcd-io:release-3.2 Oct 9, 2019
@andyliuliming
Copy link
Contributor Author

Hi @wenjiaswe @gyuho, when would the 3.2.28 version been released?
thanks.

@andyliuliming
Copy link
Contributor Author

Hi @jpbetz may I know when would 3.2.28 been release?
we need to upgrade the 3.1.x version to 3.2.x version and then to higher versions. thanks very much.

@andyliuliming
Copy link
Contributor Author

@gyuho could you please help cut one new release of 3.2? thanks.

@wenjiaswe
Copy link
Contributor

@andyliuliming @gyuho we have a couple outstanding etcd 3.2 fixes we'd like to merge (soon) and then we'll release. Thank you!

@spzala spzala mentioned this pull request Oct 16, 2019
Closed
@andyliuliming
Copy link
Contributor Author

@wenjiaswe thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hexfusion hexfusion

@wenjiaswe wenjiaswe

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyliuliming @wenjiaswe @hexfusion @gyuho