[3.5] Adding optional revision bump and mark compacted to snapshot restore #16165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjungblu
commented
Jul 3, 2023
| rbytes := newRevBytes() | ||
| revToBytes(revision{main: value}, rbytes) | ||
| tx.UnsafePut(buckets.Meta, scheduledCompactKeyName, rbytes) | ||
| } |
There was a problem hiding this comment.
if you have a better place, please let me know
Signed-off-by: Allen Ray <alray@redhat.com> Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
tjungblu
changed the title
ahrtr
reviewed
Jul 3, 2023
Comment on lines
94
to
95
| cmd.Flags().Uint64Var(&revisionBump, "bump-revision", 0, "How much to increase the latest revision after restore (required if --mark-compacted)") | ||
| cmd.Flags().BoolVar(&markCompacted, "mark-compacted", false, "Mark the latest revision after restore as the point of scheduled compaction (required if --bump-revision > 0)") |
There was a problem hiding this comment.
Please also backport #16166 to 3.5 in this PR or in a separate PR.
There was a problem hiding this comment.
Thanks, I'll cherry pick it into the PR once the review is done
…flags in snapshot restore command Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
ahrtr
approved these changes
Jul 3, 2023
serathius
approved these changes
Jul 4, 2023
|
Thanks for working on this @tjungblu . Are you planning to backport this to 3.4? I am happy to help to do that if that's ok with you. |
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.5 backport of #16029 for #16028