*: fix staticcheck lint #16626
*: fix staticcheck lint #16626
Conversation
Changed TraceKey/StartTimeKey/TokenFieldNameGRPCKey to struct{} to
follow the correct usage of context. Similar patch to etcd-io#8901.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Copy the tools/.golangci.yaml and run the linters for which we have already fixed. The temp .golangci.yaml will be removed when we fixes all the linters' issues. Signed-off-by: Wei Fu <fuweid89@gmail.com>
Makefile
Outdated
| .PHONY: verify-ineffassign | ||
| verify-ineffassign: | ||
| PASSES="ineffassign" ./scripts/test.sh | ||
| .PHONY: verify-golangcilint |
There was a problem hiding this comment.
Let's keep one target for linting.
Disable failed linters and enable it by etcd-io#16610. Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
fix-staticcheck-lint
branch
from
c3ea0c2
to
5028794
Compare
|
ping @ahrtr ~ |
| @@ -169,7 +169,6 @@ func loadKeyValueOperations(path string) (operations []porcupine.Operation, err | |||
| func persistWatchOperations(t *testing.T, lg *zap.Logger, path string, responses []model.WatchOperation) { | |||
| lg.Info("Saving watch operations", zap.String("path", path)) | |||
| file, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0755) | |||
| defer file.Close() | |||
| if err = b.myKey.Delete(); err != nil { | ||
| // Nothing to do here. We have to wait for the key to be | ||
| // deleted when the lease expires. | ||
| } | ||
| b.myKey.Delete() | ||
| // Nothing to do here even if we run into error. | ||
| // We have to wait for the key to be deleted when the lease expires. |
There was a problem hiding this comment.
Suggest to keep this unchanged. Previous source code explicitly comments why the error is ignored.
It can't even pass the static check, because the returned error should be explicitly ignored (i.e. _ = xxxx) or be checked. The reason why all the workflows are green is probably because some checks/lints are disabled?
There was a problem hiding this comment.
It can't even pass the static check, because all returned errors should be explicitly ignored (i.e. _ = xxxx) or be checked. The reason why all the workflows are green is probably because some checks/lints are disabled?
we don't enable errcheck before. So it can pass the check.
Suggest to keep this unchanged. Previous code explicitly commenting why the error is ignored.
Sounds good. I was thinking that it's good enough to keep the comment. I updated with disable linter comment. Please take a look.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
fix-staticcheck-lint
branch
from
5bbc55f
to
c6323b9
Compare
Changed TraceKey/StartTimeKey/TokenFieldNameGRPCKey to struct{} to follow the correct usage of context. Similar patch to #8901.
And this patch also copies the tools/.golangci.yaml and run the linters for which we have already fixed.The temp .golangci.yaml will be removed when we fixes all the linters' issues.
Added
lint_passin scripts/test.sh to run the golangci linters for each modules. And disable no working linters in the global golangci.yaml and enable them by #16610.Part of #16610
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.