auth, etcdserver: follow the correct usage of context #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Nov 21, 2017
auth/store.go
Outdated
| @@ -81,6 +81,10 @@ type AuthInfo struct { | |||
| Revision uint64 | |||
| } | |||
|
|
|||
| // they are used for the keys of context in the parameters of Authenticate() | |||
| type AuthenticateParamIndex struct{} | |||
There was a problem hiding this comment.
The keys of context shouldn't be string. They should be a struct of their own type. Fix etcd-io#8826
gyuho
approved these changes
Nov 21, 2017
|
@gyuho thanks for merging |
Codecov Report
@@ Coverage Diff @@
## master #8901 +/- ##
==========================================
- Coverage 76.17% 76.05% -0.12%
==========================================
Files 359 359
Lines 29740 29740
==========================================
- Hits 22653 22620 -33
- Misses 5509 5537 +28
- Partials 1578 1583 +5
Continue to review full report at Codecov.
|
fuweid
added a commit
to fuweid/etcd
that referenced
this pull request
Sep 21, 2023
Changed TraceKey/StartTimeKey/TokenFieldNameGRPCKey to struct{} to
follow the correct usage of context. Similar patch to etcd-io#8901.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
iiamabby
pushed a commit
to iiamabby/etcd
that referenced
this pull request
Nov 30, 2023
Changed TraceKey/StartTimeKey/TokenFieldNameGRPCKey to struct{} to
follow the correct usage of context. Similar patch to etcd-io#8901.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys of context shouldn't be string. They should be a struct of
their own type.
Fix #8826
/cc @gyuho