fix(standby_server): able to join the cluster containing itself #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standby server will switch to peer server if it finds that it has been contained in the cluster.
|
@xiangli-cmu @philips This is a bug fix. Plz review. |
| // Wait for a monitor cycle before checking for removal. | ||
| time.Sleep(server.ActiveMonitorTimeout + (1 * time.Second)) | ||
|
|
||
| // Verify that we now have four peers. |
There was a problem hiding this comment.
this comment does not match the code.
|
lgtm |
yichengq
added a commit
that referenced
this pull request
May 31, 2014
fix(standby_server): able to join the cluster containing itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standby server will switch to peer server if it finds that
it has been contained in the cluster.
fixes #815
fixes #810