fix(server): joinIndex is not set after recovery from full outage #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one breaks because it doesn't set joinIndex correctly.
|
@philips @xiangli-cmu please review it. |
yichengq
changed the title
|
@xiangli-cmu The one in standby server is introduced in #818, the one in peer server has existed for a long time because we don't notice it. |
|
lgtm |
yichengq
added a commit
that referenced
this pull request
Jun 2, 2014
fix(server): joinIndex is not set after recovery from full outage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one breaks because it doesn't set joinIndex correctly.
It also breaks when switch from standby mode to peer mode because it finds that it has been in the cluster.