Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fail over to next endpoint on oneshot failure #8519

Merged

Conversation

heyitsanthony
Copy link
Contributor

Fixes #8515

@rrati
Copy link

rrati commented Sep 8, 2017

This change seems to fix the issue I saw in #8515

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ba89bbb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8519   +/-   ##
=========================================
  Coverage          ?   65.88%           
=========================================
  Files             ?      360           
  Lines             ?    29523           
  Branches          ?        0           
=========================================
  Hits              ?    19452           
  Misses            ?     8403           
  Partials          ?     1668
Impacted Files Coverage Δ
client/client.go 83.72% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba89bbb...76a35e7. Read the comment docs.

@heyitsanthony heyitsanthony merged commit 80aa810 into etcd-io:master Sep 8, 2017
@heyitsanthony heyitsanthony deleted the client-oneshot-failover branch September 8, 2017 19:54
openshift-merge-robot added a commit to openshift/origin that referenced this pull request Sep 15, 2017
Automatic merge from submit-queue

Fix for etcd client oneshot cluster member cycling

Backport of etcd-io/etcd#8519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants