Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for etcd client oneshot cluster member cycling #16309

Closed
wants to merge 1 commit into from

Conversation

rrati
Copy link

@rrati rrati commented Sep 12, 2017

backport of etcd-io/etcd#8519

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2017
@rrati
Copy link
Author

rrati commented Sep 12, 2017

/assign @deads2k

@mfojtik mfojtik added this to the 3.7.0 milestone Sep 13, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Sep 14, 2017

@smarterclayton @liggitt can you guys review this pls? it is on the 3.7 list of blocker bugs.

@liggitt
Copy link
Contributor

liggitt commented Sep 14, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, rrati

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2017
@smarterclayton
Copy link
Contributor

We won't support etcd2 in 3.7

@liggitt
Copy link
Contributor

liggitt commented Sep 14, 2017

is this etcd2 only?

@liggitt liggitt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2017
@smarterclayton
Copy link
Contributor

Yes, this is etcd2 only.

@liggitt
Copy link
Contributor

liggitt commented Sep 14, 2017

great, so only needed for 3.5/3.6

@liggitt liggitt closed this Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants