Add param of withBindVolumn for EtcdClusterExtension #1092
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
force-pushed
the
Support_param_bindvolumn
branch
from
6065c52
to
f3de39a
Compare
|
It would be nice to understand why the volume mount fails, ideally this should not be something you should be able to disable as it may be required by the jetcd container |
Run unit test on windows, and use remote docker container from linux, the voulme is
Absolutely right, so still create volum for etcd test container by default, User need to use |
| @@ -46,6 +46,7 @@ public static class Builder { | |||
| private boolean ssl = false; | |||
| private List<String> additionalArgs; | |||
| private Network network; | |||
| private boolean bindVolumn = true; | |||
There was a problem hiding this comment.
- the default value is usually set in the constructor
- maybe use a better name that describe the intention i.e. bindDataDirectory
| @@ -203,7 +211,9 @@ public void start() { | |||
| @Override | |||
| public void close() { | |||
| super.close(); | |||
| deleteDataDirectory(dataDirectory); | |||
| if(bindVolumn) { | |||
There was a problem hiding this comment.
this check may not be needed as if the data directory os null, then the method won't do anything
| @@ -79,6 +80,11 @@ public EtcdContainer withClusterToken(String clusterToken) { | |||
| this.clusterToken = clusterToken; | |||
| return self(); | |||
| } | |||
|
|
|||
| public EtcdContainer withBindVolumn(boolean bindVolumn){ | |||
| this.bindVolumn=bindVolumn; | |||
There was a problem hiding this comment.
probably a checkstyle violation, please reformat the code
| @@ -57,6 +58,7 @@ public EtcdClusterImpl( | |||
| .withClusterToken(clusterName) | |||
| .withSll(ssl) | |||
| .withAdditionalArgs(additionalArgs) | |||
| .withBindVolumn(bindVolumn) | |||
|
This PR is stale because it has been open 60 days with no activity. |
|
@liangyuanpeng can you fix the findings ? |
|
@lburgazzoli is this PR up to date? I opened a #1123, I guess they are almost identical. I have all code formatter + tests there. This feature is very important to me. Thanks! |
Merged, THX ! |
|
Done in #1123 |
I use remote docker for testcontainer to run unit test and i just got the error:
So i add param of bindVolumn for this case that do not need volumn.