launcher: mounting data directory #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed formatting command. Signed-off-by: Ilia Ilinykh <ilyasyoy@gmail.com>
added settings to turn-off mounting of data directory. Signed-off-by: Ilia Ilinykh <ilyasyoy@gmail.com>
Added ability to use settings in EtcdClusterExtension. Signed-off-by: Ilia Ilinykh <ilyasyoy@gmail.com>
lburgazzoli
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for you work on this library!
About PR:
CONTRIBUTING.mdFix
CONTRIBUTING.mdThe file was not up to date. As far as I understand maven you use gradle now.
launcher: mounting data directory
We have limitations during test execution. We are not allowed to mount directories on host machine. New option
shouldMountDataDirectoryis meant to fix the problem. We will be able to turn-off mounting of the directory.Hope this wil be helpful!
Problems
I wrote some tests but I wasn't able to run them. I have 2 laptops:
gradle testtask stuck (I suppose I have this problem “Waiting to acquire shared lock on daemon addresses registry” gradle/gradle#20455)