Issue #281: Improve AverageAlgorithm class

EPL-1196: Include product.getName() in OBException
etendosoftware · Jan 22, 2024 · ffd7429 · ffd7429
1 parent b6dead7
commit ffd7429
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/org/openbravo/costing/AverageAlgorithm.java b/src/org/openbravo/costing/AverageAlgorithm.java
@@ -82,8 +82,11 @@ public BigDecimal getTransactionCost() {
   protected BigDecimal getOutgoingTransactionCost() {
     final Costing currentCosting = getProductCost();
     if (currentCosting == null) {
+      Product product = transaction.getProduct();
+      String productInfo = String.format("%s (Search Key: %s)", product.getName(), product.getSearchKey());
+
       throw new OBException("@NoAvgCostDefined@ @Organization@: " + costOrg.getName()
-          + ", @Product@: " + transaction.getProduct().getName() + ", @Date@: "
+          + ", @Product@: " + productInfo + ", @Date@: "
           + OBDateUtils.formatDate(transaction.getTransactionProcessDate()));
     }
     BigDecimal cost = currentCosting.getCost();

diff --git a/src/org/openbravo/costing/CostingUtils.java b/src/org/openbravo/costing/CostingUtils.java
@@ -152,8 +152,9 @@ public static BigDecimal getDefaultCost(Product product, BigDecimal qty, Organiz
         false);
     if (stdCost == null && pp == null) {
       throw new OBException(
-          "@NoPriceListOrStandardCostForProduct@ @Organization@: " + org.getName() + ", @Product@: "
-              + product.getSearchKey() + ", @Date@: " + OBDateUtils.formatDate(costDate));
+          "@NoPriceListOrStandardCostForProduct@ @Organization@: " + org.getName()
+              + ", @Product@: " + product.getName() + ", @ACCS_VALUE@: " + product.getSearchKey()
+              + ", @Date@: " + OBDateUtils.formatDate(costDate));
     } else if (stdCost != null && pp == null) {
       BigDecimal standardCost = getStandardCost(product, org, costDate, costDimensions, currency);
       return qty.abs().multiply(standardCost);