Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPL-1196: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #281

Closed
brunoromerosmf opened this issue Jan 8, 2024 · 0 comments · Fixed by #296
Closed

EPL-1196: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #281

brunoromerosmf opened this issue Jan 8, 2024 · 0 comments · Fixed by #296
Assignees
@tomirodeghiero
Labels
bug Something isn't working

Comments

@brunoromerosmf
Copy link
Collaborator

brunoromerosmf commented Jan 8, 2024 •
edited
Loading

Error's description

The OBException of getOutgoingTransactionCost() method of AverageAlgorithm class can be improved by showing the product.getName().
In case of variants or generic products is difficult to tell which product is throwing the exception in case of errors.

Steps to reproduce the error

  1. Create a basic product
  2. Add an purchasing to it
  3. Go to “process request“
  4. Create a record to immediately execute the process in question "Costing Background process".
  5. Execute the process and check the log, as attached here
    image

Affected version

23.4.0

Solution Design (optional)

Please find attached how Openbravo has solved this problem.
https://issues.openbravo.com/view.php?id=39863
@brunoromerosmf brunoromerosmf added the bug Something isn't working label Jan 8, 2024
@brunoromerosmf brunoromerosmf changed the title EPL-1196: AverageAlgorithm class can be improved by showing the product.getSearchKey() on the OBException EPL-1196: AverageAlgorithm class can be improved by showing the product.getName() on the OBException Jan 22, 2024
tomirodeghiero added a commit that referenced this issue Jan 22, 2024
@tomirodeghiero
Issue #281: Improve AverageAlgorithm class
ffd7429 
EPL-1196: Include product.getName() in OBException
tomirodeghiero pushed a commit that referenced this issue Jan 22, 2024
@valeg-etendo @tomirodeghiero
Issue #281: Improve AverageAlgorithm class
73c2e27 
EPL-1196: Include product.getName() in OBException
tomirodeghiero added a commit that referenced this issue Jan 22, 2024
@tomirodeghiero
Issue #281: Improve AverageAlgorithm class
734493e 
EPL-1196: Include product.getName() in OBException
@tomirodeghiero tomirodeghiero linked a pull request Jan 22, 2024 that will close this issue
Issue #281: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #296
Merged
tomirodeghiero added a commit that referenced this issue Jan 23, 2024
@tomirodeghiero
Issue #281: Refactor OBException message construction
f80786d 
EPL-1196: Directly embed product name and search key in OBException message to align with CostingUtils.java formatting
tomirodeghiero added a commit that referenced this issue Jan 23, 2024
@tomirodeghiero
Merge branch 'main' into hotfix/#281-EPL-1196
cac0a59
tomirodeghiero added a commit that referenced this issue Jan 23, 2024
@tomirodeghiero
Merge pull request #296 from etendosoftware/hotfix/#281-EPL-1196
3dc80a0 
Issue #281: AverageAlgorithm class can be improved by showing the product.getName() on the OBException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomirodeghiero tomirodeghiero

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@tomirodeghiero @brunoromerosmf