Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #281: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #296

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Issue #281: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #296

merged 3 commits into from
Jan 23, 2024

Conversation

tomirodeghiero
Copy link
Contributor

EPL-1196: Include product.getName() in OBException

@tomirodeghiero
Issue #281: Improve AverageAlgorithm class
734493e 
EPL-1196: Include product.getName() in OBException
@tomirodeghiero tomirodeghiero linked an issue Jan 22, 2024 that may be closed by this pull request
EPL-1196: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #281
Closed
@sonarscanetendo SonarScanEtendo

This comment has been minimized.

Sign in to view
@valeg-etendo valeg-etendo changed the title 📄 Hotfix/#281 epl 1196: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #294 Issue #281: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #294 Jan 22, 2024
@valeg-etendo valeg-etendo changed the title Issue #281: AverageAlgorithm class can be improved by showing the product.getName() on the OBException #294 Issue #281: AverageAlgorithm class can be improved by showing the product.getName() on the OBException Jan 22, 2024
@valeg-etendo valeg-etendo added the bug Something isn't working label Jan 22, 2024
@tomirodeghiero
Issue #281: Refactor OBException message construction
f80786d 
EPL-1196: Directly embed product name and search key in OBException message to align with CostingUtils.java formatting
@sonarscanetendo SonarScanEtendo

This comment has been minimized.

Sign in to view
@valeg-etendo valeg-etendo self-requested a review January 23, 2024 13:13
@sonarscanetendo SonarScanEtendo
Copy link

Failed

  • B Maintainability Rating on New Code (is worse than A)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (13.30% Estimated after merge)

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

@tomirodeghiero tomirodeghiero merged commit 3dc80a0 into main Jan 23, 2024
5 checks passed
@valeg-etendo valeg-etendo deleted the hotfix/#281-EPL-1196 branch January 10, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanMagnoli RomanMagnoli RomanMagnoli approved these changes

@valeg-etendo valeg-etendo valeg-etendo approved these changes

@valenvivaldi valenvivaldi valenvivaldi approved these changes

@sjcuello sjcuello Awaiting requested review from sjcuello

@sebastianbarrozo sebastianbarrozo Awaiting requested review from sebastianbarrozo

@lucas-palacios lucas-palacios Awaiting requested review from lucas-palacios

@brunoromerosmf brunoromerosmf Awaiting requested review from brunoromerosmf

@jortolanosmf jortolanosmf Awaiting requested review from jortolanosmf

@isaiasb-etendo isaiasb-etendo Awaiting requested review from isaiasb-etendo

@RubenEtendo RubenEtendo Awaiting requested review from RubenEtendo

@juanfunes1996 juanfunes1996 Awaiting requested review from juanfunes1996

@facumoyanosmf facumoyanosmf Awaiting requested review from facumoyanosmf

Assignees

@tomirodeghiero tomirodeghiero

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EPL-1196: AverageAlgorithm class can be improved by showing the product.getName() on the OBException
4 participants
@tomirodeghiero @valenvivaldi @valeg-etendo @RomanMagnoli