Skip to content

Commit

Permalink
Fix hardhat integration windows (#1485)
Browse files Browse the repository at this point in the history
* fix hardhat integration on windows

- commented in code, that was previously commented out and is required

* added entry to changelog

Co-authored-by: Ben Hauser <35276322+iamdefinitelyahuman@users.noreply.github.com>
  • Loading branch information
Minh-Trng and iamdefinitelyahuman authored May 15, 2022
1 parent d2d2a3a commit 9b5cf44
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fix download of dependencies with special characters in tag/version ([#1470](https://github.com/eth-brownie/brownie/pull/1470))
- Deepcopy config so that disconnecting and reconnecting to networks works fully ([#1466](https://github.com/eth-brownie/brownie/pull/1466))
- hardhat integration on windows ([#1482](https://github.com/eth-brownie/brownie/pull/1482))

## [1.18.1](https://github.com/eth-brownie/brownie/tree/v1.18.1) - 2022-02-15
### Fixed
Expand Down
10 changes: 5 additions & 5 deletions brownie/network/rpc/hardhat.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ def launch(cmd: str, **kwargs: Dict) -> None:
Args:
cmd: command string to execute as subprocess"""
# if sys.platform == "win32" and not cmd.split(" ")[0].endswith(".cmd"):
# if " " in cmd:
# cmd = cmd.replace(" ", ".cmd ", 1)
# else:
# cmd += ".cmd"
if sys.platform == "win32" and not cmd.split(" ")[0].endswith(".cmd"):
if " " in cmd:
cmd = cmd.replace(" ", ".cmd ", 1)
else:
cmd += ".cmd"
cmd_list = cmd.split(" ")
for key, value in [(k, v) for k, v in kwargs.items() if v and k not in IGNORED_SETTINGS]:
try:
Expand Down

0 comments on commit 9b5cf44

Please sign in to comment.