Fix hardhat integration windows #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commented in code, that was previously commented out and is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Related issue: #1482
How I did it
commented back in a piece of code, that was previously commented out and is required
How to verify it
run the commands mentioned in the issue with and without the code. the latter will fail. Of course having automated tests for the hardhat integration with windows would be the way to go, but since there is no previous work that I could start off with, I decided to pass on that.
Linting checks in hardhat.py fails (mypy has a complaint about the type in line 96), but that line was untouched by me.
Checklist