Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardhat integration windows #1485

Merged
merged 3 commits into from
May 15, 2022
Merged

Fix hardhat integration windows #1485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3779685
fix hardhat integration on windows
Minh-Trng Mar 26, 2022
bd0af02
added entry to changelog
Minh-Trng Mar 26, 2022
5800d34
Merge branch 'master' into fix_hardhat_integration_windows
iamdefinitelyahuman May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fix download of dependencies with special characters in tag/version ([#1470](https://github.com/eth-brownie/brownie/pull/1470))
- Deepcopy config so that disconnecting and reconnecting to networks works fully ([#1466](https://github.com/eth-brownie/brownie/pull/1466))
- hardhat integration on windows ([#1482](https://github.com/eth-brownie/brownie/pull/1482))

## [1.18.1](https://github.com/eth-brownie/brownie/tree/v1.18.1) - 2022-02-15
### Fixed
Expand Down
10 changes: 5 additions & 5 deletions brownie/network/rpc/hardhat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ def launch(cmd: str, **kwargs: Dict) -> None:

Args:
cmd: command string to execute as subprocess"""
# if sys.platform == "win32" and not cmd.split(" ")[0].endswith(".cmd"):
# if " " in cmd:
# cmd = cmd.replace(" ", ".cmd ", 1)
# else:
# cmd += ".cmd"
if sys.platform == "win32" and not cmd.split(" ")[0].endswith(".cmd"):
if " " in cmd:
cmd = cmd.replace(" ", ".cmd ", 1)
else:
cmd += ".cmd"
cmd_list = cmd.split(" ")
for key, value in [(k, v) for k, v in kwargs.items() if v and k not in IGNORED_SETTINGS]:
try:
Expand Down