Fix for RPC-attaching to a dockerized ganache in OSX. #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I've fixed the bug where OSX clients would get a
psutil.AccessDenied
exception when connecting to a dockerized ganache without sudo.Fixes #992
How I did it
I've added an extra check for the
platform.system()
to handle OSX clients a bit differently due to the open issue in psutils: giampaolo/psutil#1219Instead of querying all available network connections, I'm searching for the
com.docker.backend
process and attach to that. Added some tests for it as well.How to verify it
On a mac run:
and then in another terminal:
Checklist