Generalized RPC logic / basic support for Geth dev #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlinkyStitt
reviewed
Mar 18, 2021
| @@ -98,9 +98,6 @@ def test_rpc_project_cmd_settings(devnetwork, testproject, config, settings_proj | |||
| assert web3.eth.chainId == 666 | |||
| assert web3.net.version == "777" | |||
|
|
|||
| # Test if evm version is returned properly | |||
| assert devnetwork.rpc.evm_version() == cmd_settings_proj["evm_version"] | |||
There was a problem hiding this comment.
why not check this anymore?
There was a problem hiding this comment.
It was already challenging with only ganache because if the instance was already running, we had to extract it from the commandline args. In generalizing the RPC we'd now have to find a way to determine this from multiple clients, and I feel like the ++ to complexity weighed against the frequency that somebody actually has a fail from this.. simpler to just remove the check.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Generalize the logic for RPC clients and add basic support for using
geth --devviaethnode.How I did it
brownie/networks/rpc.pyhas become a subdirectory, with the__init__.pyholding a base class that can be pointed at different specific backend logic.Geth dev support is added. Brownie expects to launch or attach using
ethnode. Unfortunately, when using Geth it is not possible to time travel or rewind the chain, effectively making test isolation impossible. For some limited cases this is still useful (hello, Vyper) so I've still included it. It's not documented for now due to a combination of it's limited usefulness and overall beta-ness.This also lays the groundwork for
hardhatsupport! Once NomicFoundation/hardhat#1328 merges, it should be fairly quick on the Brownie side to make them play nice together. Then we'll have no blockers to flood poor @alcuadrado with annoying and meaningless support requests until he regrets the day he met me.