Remove ChainID + GetCodeSize check from create2deployer precompile deployment #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
changed the title
tynes
reviewed
Oct 26, 2023
mdehoog
changed the title
trianglesphere
approved these changes
Oct 26, 2023
trianglesphere
merged commit dda1a26
into
ethereum-optimism:optimism
3 of 4 checks passed
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We aligned on removing any branching logic that involves chain ID from the state transition function. This means removing the chain ID conditional for the
create2deployerdeployment introduced in #126. We also removed theGetCodeSizecheck which means the code is overridden on all op-stack chains.Tests
Updated tests.