-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy create2deployer in the next hardfork #126
Deploy create2deployer in the next hardfork #126
Conversation
Do we want this to apply to base mainnet or all chains? I lean to just base because other deployed chains should already have this. For new chains, we're looking at options to reduce this footgun. |
d8bdc3f
to
5f43b21
Compare
5f43b21
to
09d19d5
Compare
I'm just confirming that you want the bytecode from create2Deployer at 0xF49600926c7109BD66Ab97a2c036bf696e58Dbc2. I looked at some of the xdeployer byte code ( |
@trianglesphere thanks for checking. The primary reason for the bytecode difference is the removal of the An alternative would be to keep the same bytecode and leave the owner set to 0x0, which is functionally equivalent. Happy with either option. |
@mdehoog I'm fine with it as long as you are & there's a good reason behind it. |
40fb369
to
a5e446e
Compare
a5e446e
to
726e59e
Compare
@mdehoog May I ask we do not have to initialize the storage of create2deployer predeploy? This is because we are using the version which |
@pcw109550 that is correct. The deployed contract does not touch any storage. |
Description
The pcaversaccio/create2deployer helper is not able to be deployed to Base mainnet due to a nonce-increment from a deposit tx to the deployer address (see pcaversaccio/create2deployer#128).
In the discussion in pcaversaccio/create2deployer#129 it was suggested that we could deploy this in the next op-stack hard fork. This PR implements this deployment, using a
stateDb.setCode
call.The code can be verified here.
Tests