Add registry-data subcommand "bytecode" that generates a single bytecode file from hex #7488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode file from hex
protolambda
approved these changes
Oct 3, 2023
|
This PR has been added to the merge queue, and will be merged soon. |
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 3, 2023
7c49bb3
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
bytecodesubcommand of theop-chain-ops/cmd/registry-datacommand that takes in a single hex-encoded bytecode argument, and saves it to the bytecode directory in the superchain-registry.Example:
Tests
Tested by generating a file. Also tested using an existing bytecode from a genesis.json file to ensure the logic is the same.
Additional context
One of the comments in ethereum-optimism/op-geth/pull/126 was to store the bytecode for the predeploy in the superchain registry repo.