Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts-bedrock: delete dead typescript #6148

Merged
merged 13 commits into from
Jun 26, 2023
Merged

contracts-bedrock: delete dead typescript #6148

merged 13 commits into from
Jun 26, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 26, 2023

Description

This commit deletes a bunch of dead typescript code from the contracts-bedrock package.

This deletes bundling in all of the artifacts into the npm package so it will make the npm package must smaller. It will also reduce the build time by removing some steps from the build.

@tynes tynes requested review from a team as code owners June 26, 2023 18:32
@tynes tynes requested a review from maurelian June 26, 2023 18:32
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: d59ac98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit d59ac98
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/649a02963fc9100008d7475c

@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 26, 2023
@mergify mergify bot removed the conflict label Jun 26, 2023
@tynes tynes requested a review from a team as a code owner June 26, 2023 19:03
@mergify mergify bot added the sdk label Jun 26, 2023
@mergify mergify bot requested a review from roninjin10 June 26, 2023 19:04
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot woot 🎉

@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending ci

packages/sdk/src/adapters/standard-bridge.ts Show resolved Hide resolved
@tynes tynes requested a review from a team as a code owner June 26, 2023 20:28
@tynes tynes requested a review from twoshark June 26, 2023 20:28
@tynes
Copy link
Contributor Author

tynes commented Jun 26, 2023

Will rebase on #6152

This commit deletes a bunch of dead typescript code
from the contracts-bedrock package.

This deletes bundling in all of the artifacts into the
npm package so it will make the npm package must smaller.
It will also reduce the build time by removing some steps
from the build.
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #6148 (d59ac98) into develop (9087460) will increase coverage by 0.12%.
The diff coverage is 69.02%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6148      +/-   ##
===========================================
+ Coverage    44.63%   44.75%   +0.12%     
===========================================
  Files          441      442       +1     
  Lines        28931    29011      +80     
  Branches       675      691      +16     
===========================================
+ Hits         12912    12983      +71     
- Misses       14968    14976       +8     
- Partials      1051     1052       +1     
Flag Coverage Δ
bedrock-go-tests 43.68% <0.00%> (-0.01%) ⬇️
cannon-go-tests 61.71% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 58.16% <ø> (ø)
core-utils-tests 49.06% <100.00%> (+0.59%) ⬆️
fault-detector-tests 26.95% <ø> (ø)
sdk-tests 42.36% <78.57%> (+2.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-bindings/gen/main.go 0.00% <0.00%> (ø)
packages/core-utils/src/optimism/constants.ts 100.00% <ø> (ø)
packages/sdk/src/utils/contracts.ts 80.18% <67.18%> (-17.74%) ⬇️
packages/core-utils/src/optimism/index.ts 100.00% <100.00%> (ø)
packages/sdk/src/adapters/standard-bridge.ts 25.74% <100.00%> (+1.50%) ⬆️
packages/sdk/src/utils/chain-constants.ts 100.00% <100.00%> (ø)
packages/sdk/tasks/deposit-erc20.ts 10.85% <100.00%> (+4.60%) ⬆️
packages/sdk/tasks/deposit-eth.ts 8.42% <100.00%> (+3.37%) ⬆️
packages/sdk/tasks/finalize-withdrawal.ts 14.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@tynes tynes merged commit e3300c4 into develop Jun 26, 2023
10 checks passed
@tynes tynes deleted the feat/ctb-dead-ts branch June 26, 2023 21:53
tremarkley added a commit that referenced this pull request Jun 29, 2023
tremarkley added a commit that referenced this pull request Jun 29, 2023
tynes added a commit that referenced this pull request Jun 29, 2023
This was referenced Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants